add Interface in CMake for diopi_impl #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caikun-pjlab
approved these changes
Nov 7, 2023
|
|
lljbash
approved these changes
Nov 10, 2023
wiryls
force-pushed
the
add_interface_for_diopi
branch
from
fe0fff0 to
8a045a7
Compare
lljbash
reviewed
Nov 13, 2023
lljbash
approved these changes
Nov 14, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is used to fix the problem caused by pull 385
This PR will make the diopi_impl as an INTERFACE so users can decide whether to link it.
Use the following CMake args to not link libdiopi_impl.so
"WITH_DIOPI=OFF"
DICP can choose to not link diopi if they want, those who still want to link diopi can enjoy the link option "no-as-needed"